Skip to content

[SYCL] logical operation return type is boolean#17239

Merged
aelovikov-intel merged 9 commits into
intel:syclfrom
dklochkov-emb:sycl-logical-operations-return-type
Apr 22, 2025
Merged

[SYCL] logical operation return type is boolean#17239
aelovikov-intel merged 9 commits into
intel:syclfrom
dklochkov-emb:sycl-logical-operations-return-type

Conversation

@dklochkov-emb
Copy link
Copy Markdown
Contributor

@dklochkov-emb dklochkov-emb commented Feb 28, 2025 •
edited by aelovikov-intel
Loading

fix to return boolean value type of logical_and/logical_or according to
KhronosGroup/SYCL-Docs#648

CTS changes will be done in a separate PR

@dklochkov-emb dklochkov-emb self-assigned this Feb 28, 2025
@dklochkov-emb dklochkov-emb requested a review from a team as a code owner February 28, 2025 11:58
aelovikov-intel
aelovikov-intel reviewed Feb 28, 2025
View reviewed changes
Comment thread sycl/test/basic_tests/logical_operations.cpp Outdated
aelovikov-intel
aelovikov-intel reviewed Feb 28, 2025
View reviewed changes
Comment thread sycl/test/basic_tests/logical_operations.cpp
aelovikov-intel
aelovikov-intel reviewed Feb 28, 2025
View reviewed changes
Comment thread sycl/include/sycl/functional.hpp
HPS-1
HPS-1 approved these changes Mar 13, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@HPS-1 HPS-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why is TEST_VOID_TYPES added? I mean I think we can just run tests for void and non-void versions together. This we we only need 2 instead of 4 runs in total. Other than this small issue I believe you've addressed all the comments. LGTM!

aelovikov-intel
aelovikov-intel reviewed Mar 17, 2025
View reviewed changes
Comment thread sycl/include/sycl/functional.hpp Outdated
aelovikov-intel
aelovikov-intel reviewed Mar 17, 2025
View reviewed changes
Comment thread sycl/test/basic_tests/logical_operations.cpp Outdated
@dklochkov-emb
Copy link
Copy Markdown
Contributor Author

dklochkov-emb commented Apr 11, 2025

@aelovikov-intel Please, review it

aelovikov-intel
aelovikov-intel reviewed Apr 11, 2025
View reviewed changes
Comment thread sycl/test/basic_tests/logical_operations.cpp Outdated
aelovikov-intel
aelovikov-intel reviewed Apr 11, 2025
View reviewed changes
Comment thread sycl/test/basic_tests/logical_operations_void_types.cpp Outdated
steffenlarsen
steffenlarsen reviewed Apr 14, 2025
View reviewed changes
Comment thread sycl/test/basic_tests/logical_operations.cpp Outdated
@dklochkov-emb
[SYCL] avoid true in test expressions
89462df 
Co-authored-by: Steffen Larsen <steffen.larsen@intel.com>
@aelovikov-intel aelovikov-intel merged commit 6079db2 into intel:sycl Apr 22, 2025
@Pennycook Pennycook mentioned this pull request Apr 22, 2025
Open
@aelovikov-intel aelovikov-intel mentioned this pull request May 9, 2025
Open
@dklochkov-emb dklochkov-emb mentioned this pull request Jun 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HPS-1 HPS-1 HPS-1 approved these changes

+2 more reviewers

@steffenlarsen steffenlarsen steffenlarsen left review comments

@aelovikov-intel aelovikov-intel aelovikov-intel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dklochkov-emb dklochkov-emb

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dklochkov-emb @aelovikov-intel @steffenlarsen @HPS-1